* fix: /bots/{bot}
Paths "/bots/{bot}" and "/bots/{target}" must not be equivalent.
Signed-off-by: Damocles078 <hellodamocles078@gmail.com>
* fix: /channels/{group_id}/recipients/{member_id}
Paths "/channels/{group_id}/recipients/{member_id}" and "/channels/{target}/recipients/{member}" must not be equivalent.
Signed-off-by: Damocles078 <hellodamocles078@gmail.com>
* fix: /channels/{channel_id}/webhook
Paths "/channels/{target}/webhooks" and "/channels/{channel_id}/webhooks" must not be equivalent.
Signed-off-by: Damocles078 <hellodamocles078@gmail.com>
* fix: /servers/{server_id}/members/{member_id}
Paths "/servers/{target}/members/{member}" and "/servers/{server}/members/{member}" must not be equivalent.
Signed-off-by: Damocles078 <hellodamocles078@gmail.com>
* fix: /custom/emoji/{emoji_id}
Paths "/custom/emoji/{id}" and "/custom/emoji/{emoji_id}" must not be equivalent.
Signed-off-by: Damocles078 <hellodamocles078@gmail.com>
---------
Signed-off-by: Damocles078 <hellodamocles078@gmail.com>
Signed-off-by: Damocles <106018783+Damocles078@users.noreply.github.com>
118 lines
2.9 KiB
Rust
118 lines
2.9 KiB
Rust
use revolt_database::{util::reference::Reference, Database, PartialBot, User};
|
|
use revolt_models::v0::{self, DataEditBot};
|
|
use revolt_result::{create_error, Result};
|
|
use rocket::State;
|
|
|
|
use rocket::serde::json::Json;
|
|
use validator::Validate;
|
|
|
|
/// # Edit Bot
|
|
///
|
|
/// Edit bot details by its id.
|
|
#[openapi(tag = "Bots")]
|
|
#[patch("/<bot_id>", data = "<data>")]
|
|
pub async fn edit_bot(
|
|
db: &State<Database>,
|
|
user: User,
|
|
bot_id: Reference<'_>,
|
|
data: Json<DataEditBot>,
|
|
) -> Result<Json<v0::BotWithUserResponse>> {
|
|
let data = data.into_inner();
|
|
data.validate().map_err(|error| {
|
|
create_error!(FailedValidation {
|
|
error: error.to_string()
|
|
})
|
|
})?;
|
|
|
|
let mut bot = bot_id.as_bot(db).await?;
|
|
if bot.owner != user.id {
|
|
return Err(create_error!(NotFound));
|
|
}
|
|
|
|
let mut user = db.fetch_user(&bot.id).await?;
|
|
if let Some(name) = data.name {
|
|
user.update_username(db, name).await?;
|
|
}
|
|
|
|
if data.public.is_none()
|
|
&& data.analytics.is_none()
|
|
&& data.interactions_url.is_none()
|
|
&& data.remove.is_empty()
|
|
{
|
|
return Ok(Json(v0::BotWithUserResponse {
|
|
bot: bot.into(),
|
|
user: user.into_self(false).await,
|
|
}));
|
|
}
|
|
|
|
let DataEditBot {
|
|
public,
|
|
analytics,
|
|
interactions_url,
|
|
remove,
|
|
..
|
|
} = data;
|
|
|
|
let partial = PartialBot {
|
|
public,
|
|
analytics,
|
|
interactions_url,
|
|
..Default::default()
|
|
};
|
|
|
|
bot.update(
|
|
db,
|
|
partial,
|
|
remove
|
|
.into_iter()
|
|
.map(|v| v.into())
|
|
.collect(),
|
|
)
|
|
.await?;
|
|
|
|
Ok(Json(v0::BotWithUserResponse {
|
|
bot: bot.into(),
|
|
user: user.into_self(false).await,
|
|
}))
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod test {
|
|
use crate::{rocket, util::test::TestHarness};
|
|
use revolt_database::Bot;
|
|
use revolt_models::v0::{self, FieldsBot};
|
|
use rocket::http::{ContentType, Header, Status};
|
|
|
|
#[rocket::async_test]
|
|
async fn edit_bot() {
|
|
let harness = TestHarness::new().await;
|
|
let (_, session, user) = harness.new_user().await;
|
|
|
|
let (bot, _) = Bot::create(&harness.db, TestHarness::rand_string(), &user, None)
|
|
.await
|
|
.expect("`Bot`");
|
|
|
|
let response = harness
|
|
.client
|
|
.patch(format!("/bots/{}", bot.id))
|
|
.header(ContentType::JSON)
|
|
.body(
|
|
json!(v0::DataEditBot {
|
|
public: Some(true),
|
|
remove: vec![FieldsBot::Token],
|
|
..Default::default()
|
|
})
|
|
.to_string(),
|
|
)
|
|
.header(Header::new("x-session-token", session.token.to_string()))
|
|
.dispatch()
|
|
.await;
|
|
|
|
assert_eq!(response.status(), Status::Ok);
|
|
|
|
let updated_bot: v0::Bot = response.into_json().await.expect("`Bot`");
|
|
assert!(!bot.public);
|
|
assert!(updated_bot.public);
|
|
}
|
|
}
|