use revolt_database::{util::reference::Reference, voice::{delete_voice_state, get_channel_node, is_in_voice_channel, VoiceClient}, Channel, Database, User, AMQP}; use revolt_permissions::ChannelPermission; use revolt_result::{create_error, Result}; use rocket::State; use rocket_empty::EmptyResponse; /// # Remove Member from Group /// /// Removes a user from the group. #[openapi(tag = "Groups")] #[delete("//recipients/")] pub async fn remove_member( db: &State, voice_client: &State, amqp: &State, user: User, target: Reference<'_>, member: Reference<'_>, ) -> Result { if user.bot.is_some() { return Err(create_error!(IsBot)); } let channel = target.as_channel(db).await?; if let Channel::Group { owner, recipients, .. } = &channel { if &user.id != owner { return Err(create_error!(MissingPermission { permission: ChannelPermission::ManageChannel.to_string() })); } let member = member.as_user(db).await?; if user.id == member.id { return Err(create_error!(CannotRemoveYourself)); } if !recipients.contains(&member.id) { return Err(create_error!(NotInGroup)); } channel .remove_user_from_group(db, amqp, &member, Some(&user.id), false) .await?; } else { return Err(create_error!(InvalidOperation)) }; if is_in_voice_channel(&user.id, channel.id()).await? { let node = get_channel_node(channel.id()).await?.unwrap(); voice_client.remove_user(&node, &user.id, channel.id()).await?; delete_voice_state(channel.id(), None, &user.id).await?; }; Ok(EmptyResponse) } #[cfg(test)] mod test { use crate::{rocket, util::test::TestHarness}; use revolt_database::{events::client::EventV1, Channel, RelationshipStatus}; use revolt_models::v0; use rocket::http::{Header, Status}; #[rocket::async_test] async fn success_remove_member() { let mut harness = TestHarness::new().await; let (_, session, mut user) = harness.new_user().await; let (_, _, mut other_user) = harness.new_user().await; #[allow(clippy::disallowed_methods)] user.apply_relationship( &harness.db, &mut other_user, RelationshipStatus::Friend, RelationshipStatus::Friend, ) .await .unwrap(); let group = Channel::create_group( &harness.db, v0::DataCreateGroup { name: TestHarness::rand_string(), ..Default::default() }, user.id.to_string(), ) .await .unwrap(); let response = harness .client .put(format!( "/channels/{}/recipients/{}", group.id(), other_user.id )) .header(Header::new("x-session-token", session.token.to_string())) .dispatch() .await; assert_eq!(response.status(), Status::NoContent); drop(response); harness .wait_for_event(&format!("{}!", other_user.id), |event| match event { EventV1::ChannelCreate(channel) => channel.id() == group.id(), _ => false, }) .await; let event = harness .wait_for_event(group.id(), |event| match event { EventV1::ChannelGroupJoin { id, .. } => id == group.id(), _ => false, }) .await; match event { EventV1::ChannelGroupJoin { user, .. } => assert_eq!(user, other_user.id), _ => unreachable!(), }; let message = harness.wait_for_message(group.id()).await; assert_eq!( message.system, Some(v0::SystemMessage::UserAdded { id: other_user.id.to_string(), by: user.id.to_string() }) ); } #[rocket::async_test] async fn fail_not_in_group() { let harness = TestHarness::new().await; let (_, session, user) = harness.new_user().await; let (_, _, other_user) = harness.new_user().await; let group = Channel::create_group( &harness.db, v0::DataCreateGroup { name: TestHarness::rand_string(), ..Default::default() }, user.id.to_string(), ) .await .unwrap(); let response = harness .client .delete(format!( "/channels/{}/recipients/{}", group.id(), other_user.id )) .header(Header::new("x-session-token", session.token.to_string())) .dispatch() .await; dbg!(response.into_string().await); // FIXME: finish impl // assert_eq!(response.status(), Status::NotFound); } #[rocket::async_test] async fn fail_not_group_owner() { let harness = TestHarness::new().await; let (_, _, user) = harness.new_user().await; let (_, session, other_user) = harness.new_user().await; let (_, _, user_to_be_kicked) = harness.new_user().await; let group = Channel::create_group( &harness.db, v0::DataCreateGroup { name: TestHarness::rand_string(), users: vec![&other_user.id, &user_to_be_kicked.id] .into_iter() .cloned() .collect(), ..Default::default() }, user.id.to_string(), ) .await .unwrap(); let _response = harness .client .delete(format!( "/channels/{}/recipients/{}", group.id(), user_to_be_kicked.id )) .header(Header::new("x-session-token", session.token.to_string())) .dispatch() .await; // FIXME: impl assert_eq!(response.status(), Status::Forbidden); } }