feat(roles create): consider member's ranking and allow specifying custom ranking on creation

This commit is contained in:
Paul Makles
2022-02-23 14:34:29 +00:00
parent 23ec914033
commit d45b32bce6

View File

@@ -11,6 +11,7 @@ use validator::Validate;
pub struct Data { pub struct Data {
#[validate(length(min = 1, max = 32))] #[validate(length(min = 1, max = 32))]
name: String, name: String,
rank: Option<i64>,
} }
#[post("/<target>/roles", data = "<data>")] #[post("/<target>/roles", data = "<data>")]
@@ -20,17 +21,31 @@ pub async fn req(db: &Db, user: User, target: Ref, data: Json<Data>) -> Result<V
.map_err(|error| Error::FailedValidation { error })?; .map_err(|error| Error::FailedValidation { error })?;
let server = target.as_server(db).await?; let server = target.as_server(db).await?;
perms(&user) let mut permissions = perms(&user).server(&server);
.server(&server)
permissions
.throw_permission(db, Permission::ManageRole) .throw_permission(db, Permission::ManageRole)
.await?; .await?;
let member_rank = permissions.get_member_rank();
let rank = if let Some(given_rank) = data.rank {
if given_rank <= member_rank.unwrap_or(i64::MIN) {
return Err(Error::NotElevated);
}
given_rank
} else {
member_rank.unwrap_or(0).saturating_add(1)
};
let role = Role { let role = Role {
name: data.name, name: data.name,
rank,
..Default::default() ..Default::default()
}; };
Ok(json!({ Ok(json!({
"id": role.create(db, &server.id).await? "id": role.create(db, &server.id).await?,
"role": role
})) }))
} }