jmug/stoatchat
1
0
Fork 1
Code Issues Packages Projects Releases Wiki Activity

fix: don't allow users to time themselves out

Browse Source 
closes #376
This commit is contained in:
Paul Makles
2025-02-10 18:54:15 +00:00
parent 7216e9909b
commit add3f40b23
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
crates/core/result/src/lib.rs
View File

@@ -116,6 +116,7 @@ pub enum ErrorType {
max: usize, max: usize,
}, },
AlreadyInServer, AlreadyInServer,
CannotTimeoutYourself,
// ? Bot related errors // ? Bot related errors
ReachedMaximumBots, ReachedMaximumBots,

12
crates/delta/src/routes/servers/member_edit.rs
View File

@@ -15,12 +15,12 @@ use validator::Validate;
/// ///
/// Edit a member by their id. /// Edit a member by their id.
#[openapi(tag = "Server Members")] #[openapi(tag = "Server Members")]
#[patch("/<server>/members/<target>", data = "<data>")] #[patch("/<server>/members/<member>", data = "<data>")]
pub async fn edit( pub async fn edit(
db: &State<Database>, db: &State<Database>,
user: User, user: User,
server: Reference, server: Reference,
target: Reference, member: Reference,
data: Json<v0::DataMemberEdit>, data: Json<v0::DataMemberEdit>,
) -> Result<Json<v0::Member>> { ) -> Result<Json<v0::Member>> {
let data = data.into_inner(); let data = data.into_inner();
@@ -30,9 +30,9 @@ pub async fn edit(
}) })
})?; })?;
// Fetch server and target member // Fetch server and member
let mut server = server.as_server(db).await?; let mut server = server.as_server(db).await?;
let mut member = target.as_member(db, &server.id).await?; let mut member = member.as_member(db, &server.id).await?;
// Fetch our currrent permissions // Fetch our currrent permissions
let mut query = DatabasePermissionQuery::new(db, &user).server(&server); let mut query = DatabasePermissionQuery::new(db, &user).server(&server);
@@ -84,6 +84,10 @@ pub async fn edit(
.map(|x| x.contains(&v0::FieldsMember::Timeout)) .map(|x| x.contains(&v0::FieldsMember::Timeout))
.unwrap_or_default() .unwrap_or_default()
{ {
if data.timeout.is_some() && member.id.user == user.id {
return Err(create_error!(CannotTimeoutYourself));
}
permissions.throw_if_lacking_channel_permission(ChannelPermission::TimeoutMembers)?; permissions.throw_if_lacking_channel_permission(ChannelPermission::TimeoutMembers)?;
} }