fix: allow for disabling default features

This commit is contained in:
Zomatree
2025-08-12 02:35:09 +01:00
parent 050ba16d4a
commit 65fbd36624
30 changed files with 99 additions and 37 deletions

3
Cargo.lock generated
View File

@@ -6291,7 +6291,6 @@ dependencies = [
"bson", "bson",
"deadqueue", "deadqueue",
"decancer", "decancer",
"fcm_v1",
"futures", "futures",
"indexmap 1.9.3", "indexmap 1.9.3",
"isahc", "isahc",
@@ -6311,7 +6310,6 @@ dependencies = [
"revolt-permissions", "revolt-permissions",
"revolt-presence", "revolt-presence",
"revolt-result", "revolt-result",
"revolt_a2",
"revolt_okapi", "revolt_okapi",
"revolt_optional_struct", "revolt_optional_struct",
"revolt_rocket_okapi", "revolt_rocket_okapi",
@@ -6323,7 +6321,6 @@ dependencies = [
"unicode-segmentation", "unicode-segmentation",
"url-escape", "url-escape",
"validator 0.16.1", "validator 0.16.1",
"web-push",
] ]
[[package]] [[package]]

View File

@@ -11,8 +11,9 @@ description = "Revolt Backend: Configuration"
[features] [features]
anyhow = ["dep:sentry-anyhow"] anyhow = ["dep:sentry-anyhow"]
report-macros = ["revolt-result"] report-macros = ["revolt-result"]
sentry = ["dep:sentry"]
test = ["async-std"] test = ["async-std"]
default = ["test", "anyhow"] default = ["test", "sentry"]
[dependencies] [dependencies]
# Utility # Utility
@@ -32,7 +33,7 @@ log = "0.4.14"
pretty_env_logger = "0.4.0" pretty_env_logger = "0.4.0"
# Sentry # Sentry
sentry = "0.31.5" sentry = { version = "0.31.5", optional = true }
sentry-anyhow = { version = "0.38.1", optional = true } sentry-anyhow = { version = "0.38.1", optional = true }
# Core # Core

View File

@@ -6,10 +6,12 @@ use futures_locks::RwLock;
use once_cell::sync::Lazy; use once_cell::sync::Lazy;
use serde::Deserialize; use serde::Deserialize;
#[cfg(feature = "sentry")]
pub use sentry::{capture_error, capture_message, Level}; pub use sentry::{capture_error, capture_message, Level};
#[cfg(feature = "anyhow")]
pub use sentry_anyhow::capture_anyhow; pub use sentry_anyhow::capture_anyhow;
#[cfg(feature = "report-macros")] #[cfg(all(feature = "report-macros", feature = "sentry"))]
#[macro_export] #[macro_export]
macro_rules! report_error { macro_rules! report_error {
( $expr: expr, $error: ident $( $tt:tt )? ) => { ( $expr: expr, $error: ident $( $tt:tt )? ) => {
@@ -24,7 +26,7 @@ macro_rules! report_error {
}; };
} }
#[cfg(feature = "report-macros")] #[cfg(all(feature = "report-macros", feature = "sentry"))]
#[macro_export] #[macro_export]
macro_rules! capture_internal_error { macro_rules! capture_internal_error {
( $expr: expr ) => { ( $expr: expr ) => {
@@ -35,7 +37,7 @@ macro_rules! capture_internal_error {
}; };
} }
#[cfg(feature = "report-macros")] #[cfg(all(feature = "report-macros", feature = "sentry"))]
#[macro_export] #[macro_export]
macro_rules! report_internal_error { macro_rules! report_internal_error {
( $expr: expr ) => { ( $expr: expr ) => {
@@ -419,6 +421,7 @@ pub async fn config() -> Settings {
} }
/// Configure logging and common Rust variables /// Configure logging and common Rust variables
#[cfg(feature = "sentry")]
pub async fn setup_logging(release: &'static str, dsn: String) -> Option<sentry::ClientInitGuard> { pub async fn setup_logging(release: &'static str, dsn: String) -> Option<sentry::ClientInitGuard> {
if std::env::var("RUST_LOG").is_err() { if std::env::var("RUST_LOG").is_err() {
std::env::set_var("RUST_LOG", "info"); std::env::set_var("RUST_LOG", "info");
@@ -444,6 +447,7 @@ pub async fn setup_logging(release: &'static str, dsn: String) -> Option<sentry:
} }
} }
#[cfg(feature = "sentry")]
#[macro_export] #[macro_export]
macro_rules! configure { macro_rules! configure {
($application: ident) => { ($application: ident) => {

View File

@@ -10,12 +10,12 @@ description = "Revolt Backend: Database Implementation"
[features] [features]
# Databases # Databases
mongodb = ["dep:mongodb", "bson"] mongodb = ["dep:mongodb", "bson", "authifier/database-mongodb"]
# ... Other # ... Other
tasks = ["isahc", "linkify", "url-escape"] tasks = ["isahc", "linkify", "url-escape"]
async-std-runtime = ["async-std"] async-std-runtime = ["async-std", "authifier/async-std-runtime"]
rocket-impl = ["rocket", "schemars", "revolt_okapi", "revolt_rocket_okapi"] rocket-impl = ["rocket", "schemars", "revolt_okapi", "revolt_rocket_okapi", "authifier/rocket_impl"]
axum-impl = ["axum"] axum-impl = ["axum"]
redis-is-patched = ["revolt-presence/redis-is-patched"] redis-is-patched = ["revolt-presence/redis-is-patched"]
@@ -91,13 +91,8 @@ rocket = { version = "0.5.1", default-features = false, features = [
revolt_okapi = { version = "0.9.1", optional = true } revolt_okapi = { version = "0.9.1", optional = true }
revolt_rocket_okapi = { version = "0.10.0", optional = true } revolt_rocket_okapi = { version = "0.10.0", optional = true }
# Notifications
fcm_v1 = "0.3.0"
web-push = "0.10.0"
revolt_a2 = { version = "0.10", default-features = false, features = ["ring"] }
# Authifier # Authifier
authifier = { version = "1.0.15", features = ["rocket_impl"] } authifier = { version = "1.0.15" }
# RabbitMQ # RabbitMQ
amqprs = { version = "1.7.0" } amqprs = { version = "1.7.0" }

View File

@@ -1,3 +1,4 @@
#[cfg(feature = "mongodb")]
mod mongodb; mod mongodb;
mod reference; mod reference;
@@ -13,6 +14,7 @@ use authifier::Authifier;
use rand::Rng; use rand::Rng;
use revolt_config::config; use revolt_config::config;
#[cfg(feature = "mongodb")]
pub use self::mongodb::*; pub use self::mongodb::*;
pub use self::reference::*; pub use self::reference::*;
@@ -25,8 +27,10 @@ pub enum DatabaseInfo {
/// Use the mock database /// Use the mock database
Reference, Reference,
/// Connect to MongoDB /// Connect to MongoDB
#[cfg(feature = "mongodb")]
MongoDb { uri: String, database_name: String }, MongoDb { uri: String, database_name: String },
/// Use existing MongoDB connection /// Use existing MongoDB connection
#[cfg(feature = "mongodb")]
MongoDbFromClient(::mongodb::Client, String), MongoDbFromClient(::mongodb::Client, String),
} }
@@ -36,6 +40,7 @@ pub enum Database {
/// Mock database /// Mock database
Reference(ReferenceDb), Reference(ReferenceDb),
/// MongoDB database /// MongoDB database
#[cfg(feature = "mongodb")]
MongoDb(MongoDb), MongoDb(MongoDb),
} }
@@ -45,7 +50,7 @@ impl DatabaseInfo {
pub async fn connect(self) -> Result<Database, String> { pub async fn connect(self) -> Result<Database, String> {
let config = config().await; let config = config().await;
Ok(match self { match self {
DatabaseInfo::Auto => { DatabaseInfo::Auto => {
if std::env::var("TEST_DB").is_ok() { if std::env::var("TEST_DB").is_ok() {
DatabaseInfo::Test(format!( DatabaseInfo::Test(format!(
@@ -53,16 +58,20 @@ impl DatabaseInfo {
rand::thread_rng().gen_range(1_000_000..10_000_000) rand::thread_rng().gen_range(1_000_000..10_000_000)
)) ))
.connect() .connect()
.await? .await
} else if !config.database.mongodb.is_empty() { } else if !config.database.mongodb.is_empty() {
DatabaseInfo::MongoDb { #[cfg(feature = "mongodb")]
return DatabaseInfo::MongoDb {
uri: config.database.mongodb, uri: config.database.mongodb,
database_name: "revolt".to_string(), database_name: "revolt".to_string(),
} }
.connect() .connect()
.await? .await;
#[cfg(not(feature = "mongodb"))]
return Err("MongoDB not enabled.".to_string())
} else { } else {
DatabaseInfo::Reference.connect().await? DatabaseInfo::Reference.connect().await
} }
} }
DatabaseInfo::Test(database_name) => { DatabaseInfo::Test(database_name) => {
@@ -70,30 +79,36 @@ impl DatabaseInfo {
.expect("`TEST_DB` environment variable should be set to REFERENCE or MONGODB") .expect("`TEST_DB` environment variable should be set to REFERENCE or MONGODB")
.as_str() .as_str()
{ {
"REFERENCE" => DatabaseInfo::Reference.connect().await?, "REFERENCE" => DatabaseInfo::Reference.connect().await,
"MONGODB" => { "MONGODB" => {
DatabaseInfo::MongoDb { #[cfg(feature = "mongodb")]
return DatabaseInfo::MongoDb {
uri: config.database.mongodb, uri: config.database.mongodb,
database_name, database_name,
} }
.connect() .connect()
.await? .await;
#[cfg(not(feature = "mongodb"))]
return Err("MongoDB not enabled.".to_string())
} }
_ => unreachable!("must specify REFERENCE or MONGODB"), _ => unreachable!("must specify REFERENCE or MONGODB"),
} }
} }
DatabaseInfo::Reference => Database::Reference(Default::default()), DatabaseInfo::Reference => Ok(Database::Reference(Default::default())),
#[cfg(feature = "mongodb")]
DatabaseInfo::MongoDb { uri, database_name } => { DatabaseInfo::MongoDb { uri, database_name } => {
let client = ::mongodb::Client::with_uri_str(uri) let client = ::mongodb::Client::with_uri_str(uri)
.await .await
.map_err(|_| "Failed to init db connection.".to_string())?; .map_err(|_| "Failed to init db connection.".to_string())?;
Database::MongoDb(MongoDb(client, database_name)) Ok(Database::MongoDb(MongoDb(client, database_name)))
} }
#[cfg(feature = "mongodb")]
DatabaseInfo::MongoDbFromClient(client, database_name) => { DatabaseInfo::MongoDbFromClient(client, database_name) => {
Database::MongoDb(MongoDb(client, database_name)) Ok(Database::MongoDb(MongoDb(client, database_name)))
} }
}) }
} }
} }
@@ -219,12 +234,16 @@ impl Database {
Authifier { Authifier {
database: match self { database: match self {
Database::Reference(_) => Default::default(), Database::Reference(_) => Default::default(),
#[cfg(feature = "mongodb")]
Database::MongoDb(MongoDb(client, _)) => authifier::Database::MongoDb( Database::MongoDb(MongoDb(client, _)) => authifier::Database::MongoDb(
authifier::database::MongoDb(client.database("revolt")), authifier::database::MongoDb(client.database("revolt")),
), ),
}, },
config: auth_config, config: auth_config,
#[cfg(feature = "tasks")]
event_channel: Some(crate::tasks::authifier_relay::sender()), event_channel: Some(crate::tasks::authifier_relay::sender()),
#[cfg(not(feature = "tasks"))]
event_channel: None,
} }
} }
} }

View File

@@ -10,7 +10,6 @@ use serde::de::DeserializeOwned;
use serde::Serialize; use serde::Serialize;
database_derived!( database_derived!(
#[cfg(feature = "mongodb")]
/// MongoDB implementation /// MongoDB implementation
pub struct MongoDb(pub ::mongodb::Client, pub String); pub struct MongoDb(pub ::mongodb::Client, pub String);
); );

View File

@@ -25,6 +25,9 @@ pub use mongodb;
#[macro_use] #[macro_use]
extern crate bson; extern crate bson;
#[cfg(not(feature = "async-std-runtime"))]
compile_error!("async-std-runtime feature must be enabled.");
#[macro_export] #[macro_export]
#[cfg(debug_assertions)] #[cfg(debug_assertions)]
macro_rules! query { macro_rules! query {
@@ -103,6 +106,7 @@ pub mod util;
pub use models::*; pub use models::*;
pub mod events; pub mod events;
#[cfg(feature = "tasks")]
pub mod tasks; pub mod tasks;
mod amqp; mod amqp;

View File

@@ -1,3 +1,4 @@
#[cfg(feature = "mongodb")]
mod mongodb; mod mongodb;
mod reference; mod reference;

View File

@@ -2,6 +2,7 @@ use revolt_result::Result;
use crate::{Bot, FieldsBot, PartialBot}; use crate::{Bot, FieldsBot, PartialBot};
#[cfg(feature = "mongodb")]
mod mongodb; mod mongodb;
mod reference; mod reference;

View File

@@ -2,6 +2,7 @@ use revolt_result::Result;
use crate::Invite; use crate::Invite;
#[cfg(feature = "mongodb")]
mod mongodb; mod mongodb;
mod reference; mod reference;

View File

@@ -2,6 +2,7 @@ use revolt_result::Result;
use crate::ChannelUnread; use crate::ChannelUnread;
#[cfg(feature = "mongodb")]
mod mongodb; mod mongodb;
mod reference; mod reference;

View File

@@ -2,6 +2,7 @@ use revolt_result::Result;
use crate::{FieldsWebhook, PartialWebhook, Webhook}; use crate::{FieldsWebhook, PartialWebhook, Webhook};
#[cfg(feature = "mongodb")]
mod mongodb; mod mongodb;
mod reference; mod reference;

View File

@@ -8,10 +8,13 @@ use serde::{Deserialize, Serialize};
use ulid::Ulid; use ulid::Ulid;
use crate::{ use crate::{
events::client::EventV1, tasks::ack::AckEvent, Database, File, IntoDocumentPath, PartialServer, events::client::EventV1, Database, File, PartialServer,
Server, SystemMessage, User, AMQP, Server, SystemMessage, User, AMQP,
}; };
#[cfg(feature = "mongodb")]
use crate::IntoDocumentPath;
auto_derived!( auto_derived!(
#[serde(tag = "channel_type")] #[serde(tag = "channel_type")]
pub enum Channel { pub enum Channel {
@@ -646,10 +649,11 @@ impl Channel {
.private(user.to_string()) .private(user.to_string())
.await; .await;
#[cfg(feature = "tasks")]
crate::tasks::ack::queue_ack( crate::tasks::ack::queue_ack(
self.id().to_string(), self.id().to_string(),
user.to_string(), user.to_string(),
AckEvent::AckMessage { crate::tasks::ack::AckEvent::AckMessage {
id: message.to_string(), id: message.to_string(),
}, },
) )
@@ -766,6 +770,7 @@ impl Channel {
} }
} }
#[cfg(feature = "mongodb")]
impl IntoDocumentPath for FieldsChannel { impl IntoDocumentPath for FieldsChannel {
fn as_path(&self) -> Option<&'static str> { fn as_path(&self) -> Option<&'static str> {
Some(match self { Some(match self {

View File

@@ -1,5 +1,7 @@
use crate::{revolt_result::Result, Channel, FieldsChannel, PartialChannel}; use crate::{revolt_result::Result, Channel, FieldsChannel, PartialChannel};
use revolt_permissions::OverrideField; use revolt_permissions::OverrideField;
#[cfg(feature = "mongodb")]
mod mongodb; mod mongodb;
mod reference; mod reference;

View File

@@ -2,6 +2,7 @@ use revolt_result::Result;
use crate::Emoji; use crate::Emoji;
#[cfg(feature = "mongodb")]
mod mongodb; mod mongodb;
mod reference; mod reference;

View File

@@ -2,6 +2,7 @@ use revolt_result::Result;
use crate::FileHash; use crate::FileHash;
#[cfg(feature = "mongodb")]
mod mongodb; mod mongodb;
mod reference; mod reference;

View File

@@ -4,6 +4,7 @@ use crate::File;
use super::FileUsedFor; use super::FileUsedFor;
#[cfg(feature = "mongodb")]
mod mongodb; mod mongodb;
mod reference; mod reference;

View File

@@ -14,7 +14,6 @@ use validator::Validate;
use crate::{ use crate::{
events::client::EventV1, events::client::EventV1,
tasks::{self, ack::AckEvent},
util::{ util::{
bulk_permissions::BulkDatabasePermissionQuery, idempotency::IdempotencyKey, bulk_permissions::BulkDatabasePermissionQuery, idempotency::IdempotencyKey,
permissions::DatabasePermissionQuery, permissions::DatabasePermissionQuery,
@@ -22,6 +21,9 @@ use crate::{
Channel, Database, Emoji, File, User, AMQP, Channel, Database, Emoji, File, User, AMQP,
}; };
#[cfg(feature = "tasks")]
use crate::tasks::{self, ack::AckEvent};
auto_derived_partial!( auto_derived_partial!(
/// Message /// Message
pub struct Message { pub struct Message {
@@ -616,9 +618,11 @@ impl Message {
.await; .await;
// Update last_message_id // Update last_message_id
#[cfg(feature = "tasks")]
tasks::last_message_id::queue(self.channel.to_string(), self.id.to_string(), is_dm).await; tasks::last_message_id::queue(self.channel.to_string(), self.id.to_string(), is_dm).await;
// Add mentions for affected users // Add mentions for affected users
#[cfg(feature = "tasks")]
if !mentions_elsewhere { if !mentions_elsewhere {
if let Some(mentions) = &self.mentions { if let Some(mentions) = &self.mentions {
tasks::ack::queue_message( tasks::ack::queue_message(
@@ -637,6 +641,7 @@ impl Message {
} }
// Generate embeds // Generate embeds
#[cfg(feature = "tasks")]
if generate_embeds { if generate_embeds {
if let Some(content) = &self.content { if let Some(content) = &self.content {
tasks::process_embeds::queue( tasks::process_embeds::queue(
@@ -673,10 +678,12 @@ impl Message {
) )
.await?; .await?;
if !self.has_suppressed_notifications() if !self.has_suppressed_notifications()
&& (self.mentions.is_some() || self.contains_mass_push_mention()) && (self.mentions.is_some() || self.contains_mass_push_mention())
{ {
// send Push notifications // send Push notifications
#[cfg(feature = "tasks")]
tasks::ack::queue_message( tasks::ack::queue_message(
self.channel.to_string(), self.channel.to_string(),
AckEvent::ProcessMessage { AckEvent::ProcessMessage {

View File

@@ -2,6 +2,7 @@ use revolt_result::Result;
use crate::{AppendMessage, FieldsMessage, Message, MessageQuery, PartialMessage}; use crate::{AppendMessage, FieldsMessage, Message, MessageQuery, PartialMessage};
#[cfg(feature = "mongodb")]
mod mongodb; mod mongodb;
mod reference; mod reference;

View File

@@ -38,7 +38,10 @@ pub use servers::*;
pub use user_settings::*; pub use user_settings::*;
pub use users::*; pub use users::*;
use crate::{Database, MongoDb, ReferenceDb}; use crate::{Database, ReferenceDb};
#[cfg(feature = "mongodb")]
use crate::MongoDb;
pub trait AbstractDatabase: pub trait AbstractDatabase:
Sync Sync
@@ -66,6 +69,8 @@ pub trait AbstractDatabase:
} }
impl AbstractDatabase for ReferenceDb {} impl AbstractDatabase for ReferenceDb {}
#[cfg(feature = "mongodb")]
impl AbstractDatabase for MongoDb {} impl AbstractDatabase for MongoDb {}
impl std::ops::Deref for Database { impl std::ops::Deref for Database {
@@ -74,6 +79,7 @@ impl std::ops::Deref for Database {
fn deref(&self) -> &Self::Target { fn deref(&self) -> &Self::Target {
match &self { match &self {
Database::Reference(dummy) => dummy, Database::Reference(dummy) => dummy,
#[cfg(feature = "mongodb")]
Database::MongoDb(mongo) => mongo, Database::MongoDb(mongo) => mongo,
} }
} }

View File

@@ -2,6 +2,7 @@ use revolt_result::Result;
use crate::PolicyChange; use crate::PolicyChange;
#[cfg(feature = "mongodb")]
mod mongodb; mod mongodb;
mod reference; mod reference;

View File

@@ -1,6 +1,8 @@
use std::time::Duration; use std::time::Duration;
use crate::{revolt_result::Result, RatelimitEvent, RatelimitEventType}; use crate::{revolt_result::Result, RatelimitEvent, RatelimitEventType};
#[cfg(feature = "mongodb")]
mod mongodb; mod mongodb;
mod reference; mod reference;

View File

@@ -2,6 +2,7 @@ use revolt_result::Result;
use crate::Report; use crate::Report;
#[cfg(feature = "mongodb")]
mod mongodb; mod mongodb;
mod reference; mod reference;

View File

@@ -2,6 +2,7 @@ use revolt_result::Result;
use crate::Snapshot; use crate::Snapshot;
#[cfg(feature = "mongodb")]
mod mongodb; mod mongodb;
mod reference; mod reference;

View File

@@ -2,6 +2,7 @@ use revolt_result::Result;
use crate::{MemberCompositeKey, ServerBan}; use crate::{MemberCompositeKey, ServerBan};
#[cfg(feature = "mongodb")]
mod mongodb; mod mongodb;
mod reference; mod reference;

View File

@@ -1,16 +1,20 @@
use ::mongodb::SessionCursor; #[cfg(feature = "mongodb")]
use ::mongodb::{ClientSession, SessionCursor};
use revolt_result::Result; use revolt_result::Result;
use crate::{FieldsMember, Member, MemberCompositeKey, PartialMember}; use crate::{FieldsMember, Member, MemberCompositeKey, PartialMember};
#[cfg(feature = "mongodb")]
mod mongodb; mod mongodb;
mod reference; mod reference;
#[derive(Debug)] #[derive(Debug)]
#[allow(clippy::large_enum_variant)]
pub enum ChunkedServerMembersGenerator { pub enum ChunkedServerMembersGenerator {
#[cfg(feature = "mongodb")] #[cfg(feature = "mongodb")]
MongoDb { MongoDb {
session: ::mongodb::ClientSession, session: ClientSession,
cursor: Option<SessionCursor<Member>>, cursor: Option<SessionCursor<Member>>,
}, },
@@ -22,7 +26,7 @@ pub enum ChunkedServerMembersGenerator {
impl ChunkedServerMembersGenerator { impl ChunkedServerMembersGenerator {
#[cfg(feature = "mongodb")] #[cfg(feature = "mongodb")]
pub fn new_mongo(session: ::mongodb::ClientSession, cursor: SessionCursor<Member>) -> Self { pub fn new_mongo(session: ClientSession, cursor: SessionCursor<Member>) -> Self {
ChunkedServerMembersGenerator::MongoDb { ChunkedServerMembersGenerator::MongoDb {
session, session,
cursor: Some(cursor), cursor: Some(cursor),

View File

@@ -2,6 +2,7 @@ use revolt_result::Result;
use crate::{FieldsRole, FieldsServer, PartialRole, PartialServer, Role, Server}; use crate::{FieldsRole, FieldsServer, PartialRole, PartialServer, Role, Server};
#[cfg(feature = "mongodb")]
mod mongodb; mod mongodb;
mod reference; mod reference;

View File

@@ -2,6 +2,7 @@ use revolt_result::Result;
use crate::UserSettings; use crate::UserSettings;
#[cfg(feature = "mongodb")]
mod mongodb; mod mongodb;
mod reference; mod reference;

View File

@@ -4,6 +4,7 @@ use revolt_result::Result;
use crate::{FieldsUser, PartialUser, RelationshipStatus, User}; use crate::{FieldsUser, PartialUser, RelationshipStatus, User};
#[cfg(feature = "mongodb")]
mod mongodb; mod mongodb;
mod reference; mod reference;

View File

@@ -8,6 +8,7 @@ license = "AGPL-3.0-or-later"
revolt-result = { version = "0.8.8", path = "../../core/result" } revolt-result = { version = "0.8.8", path = "../../core/result" }
revolt-config = { version = "0.8.8", path = "../../core/config", features = [ revolt-config = { version = "0.8.8", path = "../../core/config", features = [
"report-macros", "report-macros",
"anyhow"
] } ] }
revolt-database = { version = "0.8.8", path = "../../core/database" } revolt-database = { version = "0.8.8", path = "../../core/database" }
revolt-models = { version = "0.8.8", path = "../../core/models", features = [ revolt-models = { version = "0.8.8", path = "../../core/models", features = [