feat: track join time

crates/delta/src/routes/servers/roles_delete.rs

@@ -1,7 +1,7 @@
 use revolt_database::{
     util::{permissions::DatabasePermissionQuery, reference::Reference},
     voice::{sync_voice_permissions, VoiceClient},
-    Database, User
+    Database, User,
 };
 use revolt_permissions::{calculate_server_permissions, ChannelPermission};
 use revolt_result::{create_error, Result};
@@ -18,7 +18,7 @@ pub async fn delete(
     user: User,
     target: Reference<'_>,
     role_id: String,
-    voice_client: &State<VoiceClient>
+    voice_client: &State<VoiceClient>,
 ) -> Result<EmptyResponse> {
     let mut server = target.as_server(db).await?;
     let mut query = DatabasePermissionQuery::new(db, &user).server(&server);
@@ -28,21 +28,22 @@ pub async fn delete(
 
     let member_rank = query.get_member_rank().unwrap_or(i64::MIN);
 
-    if let Some(role) = server.roles.remove(&role_id) {
-        if role.rank <= member_rank {
-            return Err(create_error!(NotElevated));
-        }
+    let role = server
+        .roles
+        .remove(&role_id)
+        .ok_or_else(|| create_error!(NotFound))?;
 
-        for channel_id in &server.channels {
-            let channel = Reference::from_unchecked(channel_id).as_channel(db).await?;
-
-            sync_voice_permissions(db, voice_client, &channel, Some(&server), Some(&role_id)).await?;
-        };
-
-        role.delete(db, &server.id, &role_id)
-            .await
-            .map(|_| EmptyResponse)
-    } else {
-        Err(create_error!(NotFound))
+    if role.rank <= member_rank {
+        return Err(create_error!(NotElevated));
     }
+
+    role.delete(db, &server.id, &role_id).await?;
+
+    for channel_id in &server.channels {
+        let channel = Reference::from_unchecked(channel_id).as_channel(db).await?;
+
+        sync_voice_permissions(db, voice_client, &channel, Some(&server), Some(&role_id)).await?;
+    }
+
+    Ok(EmptyResponse)
 }