refactor(quark): port channel_ack, channel_delete, channel_ edit, group_remove_member, invite_create, members_fetch, message_bulk_delete, message_clear_reactions, message_delete

#283

crates/delta/src/routes/channels/channel_delete.rs

@@ -1,34 +1,32 @@
-use revolt_quark::{
-    models::{channel::PartialChannel, Channel, User},
-    perms, Db, EmptyResponse, Error, Permission, Ref, Result,
+use revolt_database::{
+    util::{permissions::DatabasePermissionQuery, reference::Reference},
+    Channel, Database, PartialChannel, User,
 };
-use serde::{Deserialize, Serialize};
-use validator::Validate;
-
-/// # Query Parameters
-#[derive(Validate, Serialize, Deserialize, JsonSchema, FromForm)]
-pub struct OptionsChannelDelete {
-    /// Whether to not send a leave message
-    leave_silently: Option<bool>,
-}
+use revolt_models::v0;
+use revolt_permissions::{calculate_channel_permissions, ChannelPermission};
+use revolt_result::{create_error, Result};
+use rocket::State;
+use rocket_empty::EmptyResponse;
 
 /// # Close Channel
 ///
 /// Deletes a server channel, leaves a group or closes a group.
 #[openapi(tag = "Channel Information")]
 #[delete("/<target>?<options..>")]
-pub async fn req(
-    db: &Db,
+pub async fn delete(
+    db: &State<Database>,
     user: User,
-    target: Ref,
-    options: OptionsChannelDelete,
+    target: Reference,
+    options: v0::OptionsChannelDelete,
 ) -> Result<EmptyResponse> {
     let mut channel = target.as_channel(db).await?;
-    let mut perms = perms(&user).channel(&channel);
-    perms.throw_permission(db, Permission::ViewChannel).await?;
+    let mut query = DatabasePermissionQuery::new(db, &user).channel(&channel);
+    let permissions = calculate_channel_permissions(&mut query).await;
+
+    permissions.throw_if_lacking_channel_permission(ChannelPermission::ViewChannel)?;
 
     match &channel {
-        Channel::SavedMessages { .. } => Err(Error::NoEffect),
+        Channel::SavedMessages { .. } => Err(create_error!(NoEffect)),
         Channel::DirectMessage { .. } => channel
             .update(
                 db,
@@ -41,20 +39,58 @@ pub async fn req(
             .await
             .map(|_| EmptyResponse),
         Channel::Group { .. } => channel
-            .remove_user_from_group(
-                db,
-                &user.id,
-                None,
-                options.leave_silently.unwrap_or_default(),
-            )
+            .remove_user_from_group(db, &user, None, options.leave_silently.unwrap_or_default())
             .await
             .map(|_| EmptyResponse),
         Channel::TextChannel { .. } | Channel::VoiceChannel { .. } => {
-            perms
-                .throw_permission(db, Permission::ManageChannel)
-                .await?;
-
+            permissions.throw_if_lacking_channel_permission(ChannelPermission::ManageChannel)?;
             channel.delete(db).await.map(|_| EmptyResponse)
         }
     }
 }
+
+#[cfg(test)]
+mod test {
+    use crate::{rocket, util::test::TestHarness};
+    use revolt_database::{events::client::EventV1, Channel};
+    use revolt_models::v0::DataCreateGroup;
+    use rocket::http::{Header, Status};
+
+    #[rocket::async_test]
+    async fn success_delete_group() {
+        let mut harness = TestHarness::new().await;
+        let (_, session, user) = harness.new_user().await;
+
+        let group = Channel::create_group(
+            &harness.db,
+            DataCreateGroup {
+                ..Default::default()
+            },
+            user.id.clone(),
+        )
+        .await
+        .expect("`Channel`");
+
+        let response = harness
+            .client
+            .delete(format!("/channels/{}", group.id()))
+            .header(Header::new("x-session-token", session.token.to_string()))
+            .dispatch()
+            .await;
+
+        assert_eq!(response.status(), Status::NoContent);
+        drop(response);
+
+        harness
+            .wait_for_event(&group.id(), |event| match event {
+                EventV1::ChannelDelete { id, .. } => id == &group.id(),
+                _ => false,
+            })
+            .await;
+    }
+
+    // TEST: member leaves group (no delete)
+    // TEST: no effect with saved messages
+    // TEST: DM set to inactive
+    // TEST: server channel deleted
+}