feat: new permissions menus

closes #322
This commit is contained in:
Paul Makles
2022-04-22 21:06:12 +01:00
parent 4aad0493ae
commit eee1d4060f
41 changed files with 9786 additions and 5809 deletions

View File

@@ -1,5 +1,5 @@
import { observer } from "mobx-react-lite";
import { Channel } from "revolt.js/dist/maps/Channels";
import { Channel } from "revolt.js/esm/maps/Channels";
import styled from "styled-components/macro";
import { Text } from "preact-i18n";

View File

@@ -1,15 +1,14 @@
import isEqual from "lodash.isequal";
import { observer } from "mobx-react-lite";
import { Channel, API } from "revolt.js";
import { DEFAULT_PERMISSION_DIRECT_MESSAGE } from "revolt.js/esm/api/permissions";
import { useLayoutEffect, useState } from "preact/hooks";
import { useState } from "preact/hooks";
import { PermissionsLayout, Button, SpaceBetween, H1 } from "@revoltchat/ui";
import { PermissionList } from "../../../components/settings/roles/PermissionList";
import {
RoleOrDefault,
RoleSelection,
} from "../../../components/settings/roles/RoleSelection";
import { UnsavedChanges } from "../../../components/settings/roles/UnsavedChanges";
import { RoleOrDefault } from "../../../components/settings/roles/RoleSelection";
import { useRoles } from "../server/Roles";
interface Props {
@@ -24,10 +23,12 @@ export default observer(({ channel }: Props) => {
{
id: "default",
name: "Default",
permissions: channel.permissions,
permissions:
channel.permissions ??
DEFAULT_PERMISSION_DIRECT_MESSAGE,
},
] as RoleOrDefault[])
: (useRoles(channel.server!).map((role) => {
: (useRoles(channel.server! as any).map((role) => {
return {
...role,
permissions: (role.id === "default"
@@ -39,154 +40,72 @@ export default observer(({ channel }: Props) => {
};
}) as RoleOrDefault[]);
// Keep track of whatever role we're editing right now.
const [selected, setSelected] = useState("default");
const [value, setValue] = useState<API.OverrideField | number | undefined>(
undefined,
);
const currentPermission = currentRoles.find(
(x) => x.id === selected,
)!.permissions;
const currentValue = value ?? currentPermission;
// If a role gets deleted, unselect it immediately.
useLayoutEffect(() => {
if (!channel?.server?.roles) return;
if (!channel.server.roles[selected]) {
setSelected("default");
}
}, [channel.server?.roles]);
// Upload new role information to server.
function save() {
channel.setPermissions(
selected,
typeof currentValue === "number"
? currentValue
: ({
allow: currentValue.a,
deny: currentValue.d,
} as any),
);
}
return (
<div style={{ height: "100%", overflowY: "scroll" }}>
<h1>Select Role</h1>
<RoleSelection
selected={selected}
onSelect={(id) => {
setValue(undefined);
setSelected(id);
}}
roles={currentRoles}
/>
{!isEqual(currentPermission, currentValue) && (
<>
<hr />
<UnsavedChanges save={save} />
</>
)}
<hr />
<h1>Edit Permissions</h1>
<PermissionList
value={currentValue}
onChange={setValue}
filter={[
"ViewChannel",
"ReadMessageHistory",
"SendMessage",
"ManageMessages",
"ManageWebhooks",
"InviteOthers",
"SendEmbeds",
"UploadFiles",
"Masquerade",
]}
/>
</div>
);
<PermissionsLayout
channel={channel}
editor={({ selected }) => {
const currentRole = currentRoles.find(
(x) => x.id === selected,
)!;
/*const [selected, setSelected] = useState("default");
if (!currentRole) return null;
type R = { name: string; permissions: number };
const roles: { [key: string]: R } = {};
if (channel.channel_type !== "Group") {
const server = channel.server;
const a = server?.roles ?? {};
for (const b of Object.keys(a)) {
roles[b] = {
name: a[b].name,
permissions:
channel.role_permissions?.[b] ?? a[b].permissions[1],
};
}
}
// Keep track of whatever role we're editing right now.
const [value, setValue] = useState<
API.OverrideField | number | undefined
>(undefined);
const currentPermission = currentRoles.find(
(x) => x.id === selected,
)!.permissions;
const currentValue = value ?? currentPermission;
const keys = ["default", ...Object.keys(roles)];
const defaultRole = {
name: "Default",
permissions:
(channel.channel_type === "Group"
? channel.permissions
: channel.default_permissions) ?? DEFAULT_PERMISSION_DM,
};
const selectedRole = selected === "default" ? defaultRole : roles[selected];
if (!selectedRole) {
useEffect(() => setSelected("default"), []);
return null;
}
const [p, setPerm] = useState(selectedRole.permissions >>> 0);
useEffect(() => {
setPerm(selectedRole.permissions >>> 0);
}, [selected, selectedRole.permissions]);
return (
<div>
<Tip warning>This section is under construction.</Tip>
<h2>select role</h2>
{selected}
{keys.map((id) => {
const role: R = id === "default" ? defaultRole : roles[id];
return (
<Checkbox
key={id}
checked={selected === id}
onChange={(selected) => selected && setSelected(id)}>
{role.name}
</Checkbox>
);
})}
<h2>channel permissions</h2>
{Object.keys(ChannelPermission).map((perm) => {
if (perm === "View") return null;
const value =
ChannelPermission[perm as keyof typeof ChannelPermission];
if (value & DEFAULT_PERMISSION_DM) {
return (
<Checkbox
checked={(p & value) > 0}
onChange={(c) =>
setPerm(c ? p | value : p ^ value)
}>
{perm}
</Checkbox>
// Upload new role information to server.
function save() {
channel.setPermissions(
selected,
typeof currentValue === "number"
? currentValue
: ({
allow: currentValue.a,
deny: currentValue.d,
} as any),
);
}
})}
<Button
contrast
onClick={() => {
channel.setPermissions(selected, p);
}}>
click here to save permissions for role
</Button>
</div>
);*/
return (
<div>
<SpaceBetween>
<H1>Permissions for {currentRole.name}</H1>
<Button
palette="secondary"
disabled={isEqual(
currentPermission,
currentValue,
)}
onClick={save}>
Save
</Button>
</SpaceBetween>
<PermissionList
value={currentValue}
onChange={setValue}
filter={[
...(channel.channel_type === "Group"
? []
: ["ViewChannel" as "ViewChannel"]),
"ReadMessageHistory",
"SendMessage",
"ManageMessages",
"ManageWebhooks",
"InviteOthers",
"SendEmbeds",
"UploadFiles",
"Masquerade",
]}
/>
</div>
);
}}
/>
);
});

View File

@@ -4,7 +4,7 @@ import { LockAlt, HelpCircle } from "@styled-icons/boxicons-solid";
import type { AxiosError } from "axios";
import { observer } from "mobx-react-lite";
import { API } from "revolt.js";
import { User } from "revolt.js/dist/maps/Users";
import { User } from "revolt.js/esm/maps/Users";
import styled from "styled-components/macro";
import styles from "./Panes.module.scss";

View File

@@ -2,7 +2,7 @@ import { XCircle } from "@styled-icons/boxicons-regular";
import { observer } from "mobx-react-lite";
import { Virtuoso } from "react-virtuoso";
import { API } from "revolt.js";
import { Server } from "revolt.js/dist/maps/Servers";
import { Server } from "revolt.js/esm/maps/Servers";
import styles from "./Panes.module.scss";
import { Text } from "preact-i18n";

View File

@@ -2,8 +2,8 @@ import { ChevronDown } from "@styled-icons/boxicons-regular";
import { isEqual } from "lodash";
import { observer } from "mobx-react-lite";
import { Virtuoso } from "react-virtuoso";
import { Member } from "revolt.js/dist/maps/Members";
import { Server } from "revolt.js/dist/maps/Servers";
import { Member } from "revolt.js/esm/maps/Members";
import { Server } from "revolt.js/esm/maps/Servers";
import styles from "./Panes.module.scss";
import { Text } from "preact-i18n";

View File

@@ -1,7 +1,7 @@
import { Markdown } from "@styled-icons/boxicons-logos";
import isEqual from "lodash.isequal";
import { observer } from "mobx-react-lite";
import { Server } from "revolt.js/dist/maps/Servers";
import { Server } from "revolt.js/esm/maps/Servers";
import styles from "./Panes.module.scss";
import { Text } from "preact-i18n";

View File

@@ -116,48 +116,3 @@
flex-grow: 1;
}
}
.roles {
gap: 12px;
height: 100%;
display: flex;
.list {
width: 160px;
flex-shrink: 0;
overflow-y: scroll;
}
.permissions {
flex-grow: 1;
padding: 0 8px;
overflow-y: scroll;
}
.title {
gap: 8px;
display: flex;
margin-bottom: 1em;
align-items: center;
h1,
h2 {
margin: 0;
min-width: 0;
flex-grow: 1;
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
}
svg {
cursor: pointer;
}
}
.actions {
gap: 8px;
display: flex;
padding: 8px 0;
}
}

View File

@@ -1,26 +1,29 @@
import isEqual from "lodash.isequal";
import { observer } from "mobx-react-lite";
import { Server } from "revolt.js/dist/maps/Servers";
import { Server } from "revolt.js/esm/maps/Servers";
import { useLayoutEffect, useMemo, useState } from "preact/hooks";
import { useMemo, useState } from "preact/hooks";
import { useIntermediate } from "../../../context/intermediate/Intermediate";
import Button from "../../../components/ui/Button";
import Checkbox from "../../../components/ui/Checkbox";
import ColourSwatches from "../../../components/ui/ColourSwatches";
import InputBox from "../../../components/ui/InputBox";
import Overline from "../../../components/ui/Overline";
import { Button, PermissionsLayout, SpaceBetween, H1 } from "@revoltchat/ui";
import { PermissionList } from "../../../components/settings/roles/PermissionList";
import {
RoleOrDefault,
RoleSelection,
} from "../../../components/settings/roles/RoleSelection";
import { UnsavedChanges } from "../../../components/settings/roles/UnsavedChanges";
import { RoleOrDefault } from "../../../components/settings/roles/RoleSelection";
interface Props {
server: Server;
}
/**
* Hook to memo-ize role information.
* @param server Target server
* @returns Role array
*/
export function useRoles(server: Server) {
return useMemo(
() =>
@@ -38,151 +41,183 @@ export function useRoles(server: Server) {
);
}
/**
* Roles settings menu
*/
export const Roles = observer(({ server }: Props) => {
// Consolidate all permissions that we can change right now.
const currentRoles = useRoles(server);
// Keep track of whatever role we're editing right now.
const [selected, setSelected] = useState("default");
const [value, setValue] = useState<Partial<RoleOrDefault>>({});
const currentRole = currentRoles.find((x) => x.id === selected)!;
const currentRoleValue = { ...currentRole, ...value };
// If a role gets deleted, unselect it immediately.
useLayoutEffect(() => {
if (!server.roles) return;
if (!server.roles[selected]) {
setSelected("default");
}
}, [server.roles]);
// Calculate permissions we have access to on this server.
const current = server.permission;
// Upload new role information to server.
function save() {
const { permissions: permsCurrent, ...current } = currentRole;
const { permissions: permsValue, ...value } = currentRoleValue;
if (!isEqual(permsCurrent, permsValue)) {
server.setPermissions(
selected,
typeof permsValue === "number"
? permsValue
: {
allow: permsValue.a,
deny: permsValue.d,
},
);
}
if (!isEqual(current, value)) {
server.editRole(selected, value);
}
}
// Delete the role from this server.
function deleteRole() {
setSelected("default");
server.deleteRole(selected);
}
// Pull in modal context.
const { openScreen } = useIntermediate();
return (
<div style={{ height: "100%", overflowY: "scroll" }}>
<h1>Select Role</h1>
<RoleSelection
selected={selected}
onSelect={(id) => {
setValue({});
setSelected(id);
}}
roles={currentRoles}
/>
{selected !== "default" && (
<>
<hr />
<h1>Edit Role</h1>
<section>
<Overline type="subtle">Role Name</Overline>
<p>
<InputBox
value={currentRoleValue.name}
onChange={(e) =>
setValue({
...value,
name: e.currentTarget.value,
})
}
contrast
/>
</p>
</section>
<section>
<Overline type="subtle">Role Colour</Overline>
<p>
<ColourSwatches
value={currentRoleValue.colour ?? "gray"}
onChange={(colour) =>
setValue({ ...value, colour })
}
/>
</p>
</section>
<section>
<Overline type="subtle">Role Options</Overline>
<p>
<Checkbox
checked={currentRoleValue.hoist ?? false}
onChange={(hoist) =>
setValue({ ...value, hoist })
}
description="Display this role above others.">
Hoist Role
</Checkbox>
</p>
</section>
<section>
<Overline type="subtle">
Experimental Role Ranking
</Overline>
<p>
<InputBox
value={currentRoleValue.rank ?? 0}
onChange={(e) =>
setValue({
...value,
rank: parseInt(e.currentTarget.value),
})
}
contrast
/>
</p>
</section>
</>
)}
{!isEqual(currentRole, currentRoleValue) && (
<>
<hr />
<UnsavedChanges save={save} />
</>
)}
<hr />
<h1>Edit Permissions</h1>
<PermissionList
value={currentRoleValue.permissions}
onChange={(permissions) =>
setValue({ ...value, permissions } as RoleOrDefault)
<PermissionsLayout
server={server}
onCreateRole={(callback) =>
openScreen({
id: "special_input",
type: "create_role",
server: server as any,
callback,
})
}
editor={({ selected }) => {
const currentRole = currentRoles.find(
(x) => x.id === selected,
)!;
if (!currentRole) return null;
// Keep track of whatever role we're editing right now.
const [value, setValue] = useState<Partial<RoleOrDefault>>({});
const currentRoleValue = { ...currentRole, ...value };
// Calculate permissions we have access to on this server.
const current = server.permission;
// Upload new role information to server.
function save() {
const { permissions: permsCurrent, ...current } =
currentRole;
const { permissions: permsValue, ...value } =
currentRoleValue;
if (!isEqual(permsCurrent, permsValue)) {
server.setPermissions(
selected,
typeof permsValue === "number"
? permsValue
: {
allow: permsValue.a,
deny: permsValue.d,
},
);
}
if (!isEqual(current, value)) {
server.editRole(selected, value);
}
}
/>
{selected !== "default" && (
<>
<hr />
<h1>Danger Zone</h1>
<Button contrast error onClick={deleteRole}>
Delete Role
</Button>
</>
)}
</div>
// Delete the role from this server.
function deleteRole() {
server.deleteRole(selected);
}
return (
<div>
<SpaceBetween>
<H1>Edit {currentRole.name}</H1>
<Button
palette="secondary"
disabled={isEqual(
currentRole,
currentRoleValue,
)}
onClick={save}>
Save
</Button>
</SpaceBetween>
<hr />
{selected !== "default" && (
<>
<section>
<Overline type="subtle">Role Name</Overline>
<p>
<InputBox
value={currentRoleValue.name}
onChange={(e) =>
setValue({
...value,
name: e.currentTarget.value,
})
}
contrast
/>
</p>
</section>
<section>
<Overline type="subtle">
Role Colour
</Overline>
<p>
<ColourSwatches
value={
currentRoleValue.colour ??
"gray"
}
onChange={(colour) =>
setValue({ ...value, colour })
}
/>
</p>
</section>
<section>
<Overline type="subtle">
Role Options
</Overline>
<p>
<Checkbox
checked={
currentRoleValue.hoist ?? false
}
onChange={(hoist) =>
setValue({ ...value, hoist })
}
description="Display this role above others.">
Hoist Role
</Checkbox>
</p>
</section>
<section>
<Overline type="subtle">
Role Ranking
</Overline>
<p>
<InputBox
type="number"
value={currentRoleValue.rank ?? 0}
onChange={(e) =>
setValue({
...value,
rank: parseInt(
e.currentTarget.value,
),
})
}
contrast
/>
</p>
</section>
</>
)}
<h1>Edit Permissions</h1>
<PermissionList
value={currentRoleValue.permissions}
onChange={(permissions) =>
setValue({
...value,
permissions,
} as RoleOrDefault)
}
/>
{selected !== "default" && (
<>
<hr />
<h1>Danger Zone</h1>
<Button
palette="error"
compact
onClick={deleteRole}>
Delete Role
</Button>
</>
)}
</div>
);
}}
/>
);
});