refactor: generate ca now generates and writes its own private key.

internal/clis/hmpki/generate.go

@@ -5,28 +5,34 @@ import (
 )
 
 // Needed by all subcommands.
-var Output string
-
-// Needed by some subcommands.
-var KeyFile string
+var Name string
+var OutDir string
 
 func init() {
 	rootCmd.AddCommand(generateCmd)
 
-	// All "generate" commands output an artifact to a file,
-	// be it a key or a cert, etc.
+	// Name for artifacts being written to file(s).
 	generateCmd.PersistentFlags().StringVarP(
-		&Output,
-		"output",
-		"o",
+		&Name,
+		"name",
+		"n",
 		"",
-		"output filename",
+		"name of the artifact being benerated",
 	)
-	generateCmd.MarkPersistentFlagRequired("output")
-	generateCmd.MarkPersistentFlagFilename("output")
+	generateCmd.MarkPersistentFlagRequired("name")
+
+	// Output direcotry.
+	generateCmd.PersistentFlags().StringVar(
+		&OutDir,
+		"output-dir",
+		".",
+		"output directory for artifacts produced by this command, defaults to the current directory",
+	)
+	generateCmd.MarkPersistentFlagRequired("output-dir")
+	generateCmd.MarkPersistentFlagDirname("output-dir")
 }
 
 var generateCmd = &cobra.Command{
 	Use:   "generate",
-	Short: "Generate pki resources (keys/certs)",
+	Short: "Generate pki resources (cas/keys/certs)",
 }