HMC/handmade-revolt
2
0
Fork 0
forked from abner/for-legacy-web
Code Pull Requests Actions Activity

Resolve remaining review notes

Browse Source
This commit is contained in:
bree
2021-07-04 21:22:33 -04:00
parent 8ece647857
commit c194fff7fd
5 changed files with 16 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/context/revoltjs/RevoltClient.tsx
View File

@@ -34,7 +34,9 @@ export interface ClientOperations {
openDM: (user_id: string) => Promise<string>;
}
// TODO: remove temporary non-null assertions and properly typecheck these as they aren't always immedietely initialized
// By the time they are used, they should all be initialized.
// Currently the app does not render until a client is built and the other two are always initialized on first render.
// - insert's words
export const AppContext = createContext<Client>(null!);
export const StatusContext = createContext<ClientStatus>(null!);
export const OperationsContext = createContext<ClientOperations>(null!);
@@ -94,7 +96,7 @@ function Context({ auth, children, dispatcher }: Props) {
const login = () =>
dispatcher({
type: "LOGIN",
session: client.session! // TODO: verify that this null assertion is correct
session: client.session! // This [null assertion] is ok, we should have a session by now. - insert's words
});
if (onboarding) {