feat(server/set_default): prevent users giving perm they don't have

This commit is contained in:
Paul Makles
2022-02-23 15:59:21 +00:00
parent 437a620274
commit fcbaab7bcb

View File

@@ -3,7 +3,7 @@ use serde::{Deserialize, Serialize};
use revolt_quark::{ use revolt_quark::{
models::{server::PartialServer, Server, User}, models::{server::PartialServer, Server, User},
perms, Db, Permission, Ref, Result, perms, Db, Error, Permission, Ref, Result,
}; };
#[derive(Serialize, Deserialize)] #[derive(Serialize, Deserialize)]
@@ -16,12 +16,18 @@ pub async fn req(db: &Db, user: User, target: Ref, data: Json<Data>) -> Result<J
let data = data.into_inner(); let data = data.into_inner();
let mut server = target.as_server(db).await?; let mut server = target.as_server(db).await?;
perms(&user) let mut permissions = perms(&user).server(&server);
.server(&server)
permissions
.throw_permission(db, Permission::ManagePermissions) .throw_permission(db, Permission::ManagePermissions)
.await?; .await?;
// ! FIXME_PERMISSIONS if !permissions
.has_permission_value(db, data.permissions)
.await?
{
return Err(Error::CannotGiveMissingPermissions);
}
server server
.update( .update(