From 64d1126af9303aaf6060b995aeae9184b6d885cf Mon Sep 17 00:00:00 2001
From: Paul Makles <paulmakles@gmail.com>
Date: Tue, 22 Feb 2022 22:51:04 +0000
Subject: [PATCH] fix(message delete): throw instead of manual check

---
 src/routes/channels/message_delete.rs | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/src/routes/channels/message_delete.rs b/src/routes/channels/message_delete.rs
index 40f4f2b1..c77bdc02 100644
--- a/src/routes/channels/message_delete.rs
+++ b/src/routes/channels/message_delete.rs
@@ -7,15 +7,11 @@ pub async fn req(db: &Db, user: User, target: Ref, msg: Ref) -> Result<EmptyResp
         return Err(Error::NotFound);
     }
 
-    if message.author != user.id
-        || !{
-            perms(&user)
-                .channel(&target.as_channel(db).await?)
-                .has_permission(db, Permission::ManageMessages)
-                .await?
-        }
-    {
-        return Error::from_permission(Permission::ManageMessages);
+    if message.author != user.id {
+        perms(&user)
+            .channel(&target.as_channel(db).await?)
+            .throw_permission(db, Permission::ManageMessages)
+            .await?;
     }
 
     message.delete(db).await.map(|_| EmptyResponse)