Merge remote-tracking branch 'revoltchat/master' into webhooks

crates/delta/src/routes/bots/fetch.rs

@@ -1,36 +1,33 @@
-use revolt_quark::{
-    models::{Bot, User},
-    Db, Error, Ref, Result,
-};
-use rocket::serde::json::Json;
-use serde::Serialize;
-
-/// # Bot Response
-#[derive(Serialize, JsonSchema)]
-pub struct BotResponse {
-    /// Bot object
-    bot: Bot,
-    /// User object
-    user: User,
-}
+use revolt_database::{util::reference::Reference, Database};
+use revolt_models::v0::FetchBotResponse;
+use revolt_quark::{models::User, Error, Result};
+use rocket::{serde::json::Json, State};
 
 /// # Fetch Bot
 ///
 /// Fetch details of a bot you own by its id.
 #[openapi(tag = "Bots")]
-#[get("/<target>")]
-pub async fn fetch_bot(db: &Db, user: User, target: Ref) -> Result<Json<BotResponse>> {
+#[get("/<bot>")]
+pub async fn fetch_bot(
+    db: &State<Database>,
+    user: User,
+    bot: Reference,
+) -> Result<Json<FetchBotResponse>> {
     if user.bot.is_some() {
         return Err(Error::IsBot);
     }
 
-    let bot = target.as_bot(db).await?;
+    let bot = bot.as_bot(db).await.map_err(Error::from_core)?;
     if bot.owner != user.id {
         return Err(Error::NotFound);
     }
 
-    Ok(Json(BotResponse {
-        user: db.fetch_user(&bot.id).await?.foreign(),
-        bot,
+    Ok(Json(FetchBotResponse {
+        user: revolt_models::v0::User::from(
+            db.fetch_user(&bot.id).await.map_err(Error::from_core)?,
+            None,
+        )
+        .await,
+        bot: bot.into(),
     }))
 }

crates/delta/src/routes/bots/fetch_public.rs

@@ -1,44 +1,25 @@
-use revolt_quark::{
-    models::{File, User},
-    Db, Error, Ref, Result,
-};
+use revolt_database::Database;
+use revolt_models::v0::PublicBot;
+use revolt_quark::{models::User, Error, Ref, Result};
 
 use rocket::serde::json::Json;
-use serde::{Deserialize, Serialize};
-
-/// # Public Bot
-#[derive(Serialize, Deserialize, JsonSchema)]
-pub struct PublicBot {
-    /// Bot Id
-    #[serde(rename = "_id")]
-    id: String,
-    /// Bot Username
-    username: String,
-    /// Profile Avatar
-    #[serde(skip_serializing_if = "Option::is_none")]
-    avatar: Option<File>,
-    /// Profile Description
-    #[serde(skip_serializing_if = "Option::is_none")]
-    description: Option<String>,
-}
+use rocket::State;
 
 /// # Fetch Public Bot
 ///
 /// Fetch details of a public (or owned) bot by its id.
 #[openapi(tag = "Bots")]
 #[get("/<target>/invite")]
-pub async fn fetch_public_bot(db: &Db, user: Option<User>, target: Ref) -> Result<Json<PublicBot>> {
-    let bot = target.as_bot(db).await?;
+pub async fn fetch_public_bot(
+    db: &State<Database>,
+    user: Option<User>,
+    target: Ref,
+) -> Result<Json<PublicBot>> {
+    let bot = db.fetch_bot(&target.id).await.map_err(Error::from_core)?;
     if !bot.public && user.map_or(true, |x| x.id != bot.owner) {
         return Err(Error::NotFound);
     }
 
-    let user = db.fetch_user(&bot.id).await?;
-
-    Ok(Json(PublicBot {
-        id: bot.id,
-        username: user.username,
-        avatar: user.avatar,
-        description: user.profile.and_then(|p| p.content),
-    }))
+    let user = db.fetch_user(&bot.id).await.map_err(Error::from_core)?;
+    Ok(Json(PublicBot::from(bot, user)))
 }

crates/delta/src/routes/servers/invites_fetch.rs

@@ -1,6 +1,6 @@
 use revolt_quark::{
     models::{Invite, User},
-    perms, Db, Error, Permission, Ref, Result,
+    perms, Db, Permission, Ref, Result,
 };
 
 use rocket::serde::json::Json;
@@ -11,10 +11,6 @@ use rocket::serde::json::Json;
 #[openapi(tag = "Server Members")]
 #[get("/<target>/invites")]
 pub async fn req(db: &Db, user: User, target: Ref) -> Result<Json<Vec<Invite>>> {
-    if user.bot.is_some() {
-        return Err(Error::IsBot);
-    }
-
     let server = target.as_server(db).await?;
     perms(&user)
         .server(&server)

crates/delta/src/routes/servers/server_create.rs

@@ -44,6 +44,10 @@ pub async fn req(
     user: User,
     info: Json<DataCreateServer>,
 ) -> Result<Json<CreateServerResponse>> {
+    if user.bot.is_some() {
+        return Err(Error::IsBot);
+    }
+
     let info = info.into_inner();
     info.validate()
         .map_err(|error| Error::FailedValidation { error })?;